Add a dependency check for cadence imports #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is the use case for this ? |
|
There is a desire on testnet to report and potentially fail transactions that use unstaged contracts, to remind people that their contracts are not staged. |
janezpodhostnik
changed the title
ramtinms
approved these changes
May 14, 2024
sideninja
approved these changes
May 14, 2024
turbolent
reviewed
May 14, 2024
turbolent
reviewed
May 14, 2024
janezpodhostnik
force-pushed
the
janez/dependency-check
branch
from
5d0fdaf to
395d26a
Compare
yes exactly. That part will be implemented in the smart contract, which gives us greater flexibility and means that we do not have to use HCU to deploy changes. |
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5858
Add a dependency check to the FVM code.
If enabled the FVM will expect a function with the following signature:
The FVM will call this function at the end of the transaction (after fee deduction). It will inject all dependencies of the transaction and all the authorizers of the transaction + the payer. The call of the function is not metered.
If the function is not there the FVM will quietly continue (It will log the problem).
If the function panics the transaction will fail (the panic message will be in the error). The function can emit events (but they will only be emitted if the transaction doesn't fail).
This is a v0.33 only feature